D20892: Eliminate some GCC warnings during compilation.
Laurent Montel <[email protected]>
| Newsgroups | gmane.comp.kde.devel.games |
|---|---|
| Message-ID | <[email protected]> |
mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > abstract_fc_solve_solver.h:28 > virtual ~FcSolveSolver(); > - virtual int get_possible_moves(int *a, int *numout) = 0; > - virtual bool isWon(); > - virtual void make_move(MOVE *m); > - virtual void undo_move(MOVE *m); > - virtual int getOuts(); > - virtual unsigned int getClusterNumber(); > - virtual void translate_layout() = 0; > - virtual void unpack_cluster( unsigned int k ); > - virtual MoveHint translateMove(const MOVE &m) = 0; > - virtual SolverInterface::ExitStatus patsolve( int _max_positions = -1); > + virtual int get_possible_moves(int *a, int *numout) Q_DECL_OVERRIDE = 0; > + virtual bool isWon() Q_DECL_OVERRIDE; remove virtual keyword. Q_DECL_OVERRIDE is enough. And I think that we can use override directly. REPOSITORY R410 KPatience REVISION DETAIL https://phabricator.kde.org/D20892 To: shlomif, #kde_games, mlaurent Cc: mlaurent, kde-games-devel