D24570: Fix kolflib_export

twighk updated this revision to Diff 67801.
twighk added a comment.


  Instead of removing KOLFLIB, set a define when building it so it choses the correct dll linkage.
  
  Make the library STATIC instead of SHARED in the cmakelists.txt . It was having different problems where it couldn't find things that were in the library when linking:
  
    Creating library lib\kolf.lib and object lib\kolf.exp                                                                              main.cpp.obj : error LNK2001: unresolved external symbol "public: static struct QMetaObject const KolfGame::staticMetaObject" (?staticMetaObject@KolfGame@@2UQMetaObject@@B)                                                                                                main.cpp.obj : error LNK2001: unresolved external symbol "public: static struct QMetaObject const KolfWindow::staticMetaObject" (?staticMetaObject@KolfWindow@@2UQMetaObject@@B)                                                                                            bin\kolf.exe : fatal error LNK1120: 2 unresolved externals

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24570?vs=67746&id=67801

REVISION DETAIL
  https://phabricator.kde.org/D24570

AFFECTED FILES
  kolf-19.08.2/CMakeLists.txt

To: twighk, #kde_games
Cc: vonreth, yurchor, kde-games-devel, krippendorf, hoetzel, hechenlan, bencreasy