D25199: Fix some compiler warnings
Yuri Chornoivan <[email protected]>
| Newsgroups | gmane.comp.kde.devel.games |
|---|---|
| Message-ID | <[email protected]> |
yurchor marked an inline comment as done.
yurchor added a comment.
In D25199#563837 <https://phabricator.kde.org/D25199#563837>, @aacid wrote:
> About the iris warnings, since @nhirsl seems right and we don't seem to use it, i'd suggest to just do
>
> diff --git a/ksirk/CMakeLists.txt b/ksirk/CMakeLists.txt
> index 4d5d2f9..1dcad94 100644
> --- a/ksirk/CMakeLists.txt
> +++ b/ksirk/CMakeLists.txt
> @@ -3,7 +3,7 @@ check_include_files(sys/stropts.h SYS_STROPTS_H_FOUND)
> configure_file(config-ksirk.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-ksirk.h)
>
> add_subdirectory(skins)
> -add_subdirectory(iris)
> +# add_subdirectory(iris)
> add_subdirectory(icons)
>
> # FIND_PACKAGE(ZLIB REQUIRED)
>
>
> for now, what do you think?
This does not compile (linking failed, then wrong includes, etc.). This needs more complicated patching, which is out of the scope of the current patch.
REPOSITORY
R413 KsirK
REVISION DETAIL
https://phabricator.kde.org/D25199
To: yurchor, #kde_games
Cc: nhirsl, aacid, chehrlic, kde-games-devel