D27105: Add const values 'nRows' and 'nCols'
Yanjie He <[email protected]>
| Newsgroups | gmane.comp.kde.devel.games |
|---|---|
| Message-ID | <[email protected]> |
yanjiehe added inline comments. INLINE COMMENTS > chehrlic wrote in commondefs.h:45 > static const -> constexpr Thank you for your comment! But I doubt that change static const -> constexpr will have any improvement in performance or readability. Basic they are doing the same thing in this situation. I would still prefer using 'static const' because the code does not involve any computation in compile time. REPOSITORY R411 KReversi REVISION DETAIL https://phabricator.kde.org/D27105 To: yanjiehe, #kde_games Cc: chehrlic, kde-games-devel