D27432: WIP: fix moveCount for Freecell
Fabian Kosmale <[email protected]>
| Newsgroups | gmane.comp.kde.devel.games |
|---|---|
| Message-ID | <[email protected]> |
fabiank created this revision. fabiank added reviewers: aacid, shlomif, yurchor, piotrkakol. Herald added a reviewer: KDE Games. Herald added a subscriber: kde-games-devel. fabiank requested review of this revision. REVISION SUMMARY Instead of changing the logic in dealer.cpp as in D27336 <https://phabricator.kde.org/D27336>, only change the moveCount function for FreeCell. Pro: - less invasive change, less likely to cause regressions in other places Contra: - This might only pamper over an actual issue, which D27336 <https://phabricator.kde.org/D27336> would fix. TEST PLAN - Started a new Freecell game (without multiple aces), and checked that the count is sound - Loaded existing Freecell games, and verified that the count is shown as expected - Started Freecell game where the initial state had two aces; verified that after the auto move completed, the displayed count was 2 (and not 1) REPOSITORY R410 KPatience REVISION DETAIL https://phabricator.kde.org/D27432 AFFECTED FILES dealer.h freecell.cpp freecell.h To: fabiank, aacid, shlomif, yurchor, piotrkakol, #kde_games Cc: kde-games-devel