Re: Commit to Bluedevil repo

Sune Vuorela <[email protected]>
Newsgroups gmane.comp.kde.devel.general
Organization pusling.com internet technologies
Message-ID <[email protected]>
On 2025-12-07, Enol P. <[email protected]> wrote:
> The commit i've mentioned: https://invent.kde.org/plasma/bluedevil/-/commit/88222071c80bcbcee32071e2c413a8f80db64947

Thank you for your contribution. Shite happens from time to time, and
great that you are honest about it.

In general (not specific to your changeset)

There are basically two ways out:
 1) Revert and create a new MR
 2) Tell people and let them know

If the change is likely uncontroversial and I'm certain the change is an
improvement, I have been going for 2). If I'm in doubt about the
correctness or the change itself could be controversial, I've been going
for 1).


I think in this case, going for 2) is entirely appropriate.

/Sune
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.