Re: Commit to Bluedevil repo

Konstantin Kharlamov <[email protected]>
Newsgroups gmane.comp.kde.devel.general
Message-ID <[email protected]>
On Mon, 2025-12-08 at 19:58 +1030, Justin Zobel wrote:
>  
> On 8/12/25 19:32, Konstantin Kharlamov wrote:
>  
>  
> >  
> > On Sun, 2025-12-07 at 02:06 +0100, Enol P. wrote:
> >  
> > >  
> > >  
> > > Hi all,
> > >  
> > >  
> > >  
> > > I've just committed to master a change for a toolptip text in
> > > Bluedevil's KCM. Revert it if necessary because I thought
> > > GitLab's
> > > web IDE would be smarter enough to make a pull request instead.
> > > Sorry
> > > if I missed any contributor guidelines for Bluedevil or if any
> > > commit
> > > should be discussed in this mail list first. I'm just a
> > > translator
> > > and my git knowledge is limited.
> > >  
> > >  
> > >  
> > > The commit i've mentioned:
> > > https://invent.kde.org/plasma/bluedevil/-/commit/88222071c80bcbcee32071e2c413a8f80db64947
> > >  
> >  
> > FWIW, it's a pretty common mistake, and for this reason I usually
> > disable "push" to master in project settings for projects I manage,
> > so
> > any possible commit could only go via merge-request and hence via
> > CI.
> > 
> > Just mentioning in case Bluedevil maintainers might want to do the
> > same.
> >  
>  I alias 'gp' to a script that makes me confirm I want to push if the
> current branch is called 'master' or 'main'. 

Fair enough!

It's just, from maintenance viewpoint you can't be sure other people do
that, so it really should be solved on the server-side, so it's
applicable to everyone.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.