Windows signing restored
Ben Cooksley <[email protected]>
| Newsgroups | gmane.comp.kde.devel.general |
|---|---|
| Message-ID | <CA+XidOEAyB0m7JKZn9O0sGMqvecLvzfihTmHZqZqjUYDizo_7g@mail.gmail.com> |
Hi all, This evening I have completed the necessary setup to restore Windows signing using our new certificate. Conventional Windows signing should now be operational again. Unfortunately due to assumptions in Craft surrounding how X.509 certificate subject names are constructed, it is not possible to restore appx signing at this time as it fails due to the following error: Aug 26 11:09:02 jarvis python[30701]: java.lang.IllegalArgumentException: The app manifest publisher name (CN=K Desktop Environment e. V., O=K Desktop Environment e. V., S=Berlin, C=DE) must match the subject name of the signing certificate (SERIALNUMBER=VR 31685,jurisdictionCountry=DE,BusinessCategory=Private Organization,C=DE,ST=Berlin,O=K Desktop Environment e.V.,CN=K Desktop Environment e.V.) (Note for those looking to update our Craft configuration - the above is not the subject name that Windows will accept, you need SERIALNUMBER=VR 31685, 1.3.6.1.4.1.311.60.2.1.3=DE, 2.5.4.15=Private Organization, C=DE, S=Berlin, O=K Desktop Environment e.V., CN=K Desktop Environment e.V. for that) Craft also fails to pick up this failure and reports success. While validating this functionality I also observed that Craft is performing an excessive number of signing operations. The first it does when doing the initial build, with subsequent signings being done for the tarball / exe installer and the files to be used in the appx packaging. The result of this is: - Longer time to build as we do 3 trips to the Notary for the same set of files - should be 1 (which wastes CI builder time) - More signing operations being performed (which means greater cost for us, as the new certificate lives in a HSM and usage is a charged for - thankfully the cost is minimal) - Executables / dlls having two signatures on them (probably going to upset/break something somewhere) - The resulting files in the .appx and .exe/.7z bundles having different signatures / hashes If we could please look into those issues with Craft that would be appreciated. Thanks, Ben