Re: Encoding patch; please commit (#46178)
Christoph Cullmann <[email protected]> Thu, 22 Aug 2002 20:21:53 +0200
| Newsgroups | gmane.comp.kde.devel.kate |
|---|---|
| Message-ID | <[email protected]> |
On Wednesday 21 August 2002 16:36, Виктор С. Грищенко \(Viktor S. Grichenko\) wrote:
> Hello!
>
> HEAD Kate have a bug which annoys me since 3.0 was released.
> Sometimes default encoding in KateFileDialog combo turns into
> pt154 (from my locale-default Cp 1251).
> It's because KateFileDialog constructor assumes encoding
> parameter to be in QT form ("CP 1251") while it could be KGlobal
> style "Cp 1251". It is also interesting that KateFileDialog's
> own exec() returns "Cp 1251".
> Patch for kfiledialog.cpp is attached (correctly accepts both
> capitalizations).
>
> Also I've made some clean-up in KateViewManager removing
> m_encoding variable as unnecessary and compacting openURL
> method. Patches are also applied.
Will test the patch and commit if it works ;)
cu
Christoph
--
Christoph Cullmann
Kate/KDE developer
[email protected]
http://kate.kde.org