Re: new searchengine
Stanislav Visnovsky <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kbabel |
|---|---|
| Message-ID | <[email protected]> |
Dňa Po 9. Jún 2003 16:52 Marco Wegner napísal: > Am Montag, 9. Juni 2003 07:19 schrieb Stanislav Visnovsky: > > DĹ�a Ne 8. JĂşn 2003 01:38 Marco Wegner napĂsal: > > > On Tuesday 03 June 2003 12:16, Marco Wegner wrote: > > > > On Tuesday 03 June 2003 11:36, Andrea Rizzi wrote: > > > > > Can we change kbmailer.cpp so that filenames in archives are > > > > > provided with path? (I implemented it on my local copy of kbabel > > > > > but it use absolute paths and I think it is a security problem, > > > > > i.e. contains info about fs hieracy. It should be relative to > > > > > catalogs-root-dir but I have no idea about how can I access it) > > > > > > > > Yes, I think I could do that... > > > > > > I have a question concerning the implementation: Should single file > > > archives contain the relative path as well? Or should this be > > > configurable like the single file compression? > > > > IMHO it should store relative path. > > Okay, I have an implementation for this now (patch attached). Please test > it. Comments and suggestions are welcome as usual. > > The files in the archive are stored relative to the PoBaseDir variable in > kbabelrc. If this variable is not set (in case Catalog Manager has never > run before) the files are stored without paths (i.e. just as before). > > Catalog Manager does notify KBabelMailer of a changed PoBaseDir as well. But what if there is a specified project file? You're always asking for the kbabelrc stuff. Otherwise the patch looks OK. Stanislav