Re: [PATCH] Temporary fix for too wide combo box in SVN/CVS commit (#115296)

On Saturday 29 October 2005 23:41, Nicolas Goutte wrote:
> The attached patch is for kdesdk/kbabel/catalogmanager

I think that I have made my own fedback. :-)

I have remembered that there is the class KStringHandler (in kdecore), which 
has nice functions that I could use.
Also for avoid that the "short duplicate" problem, I could use the index of 
the combobox instead of the text of the entry.
(Also I must check if KComboBox should not be used instead of QComboBox, 
however I do not remember the advantages for a non-editable combo box.)

>
> It tries to make a temporary fix to the symptom that the combo box in the
> SVN/ CVS commit dialog becomes too wide if there is at least a long old log
> in the log history and therefore makes the dialog useless (as the buttons
> are near the right, out of screen). (Bug #115296)
>
> The patch is only for SVN for now. It has a few drawback. It cuts the
> strings at 80 characters and does not care about duplicates.
>
> I suppose that it could be committed so, until someone of us takes the time
> to make a better fix (for example cut at a certain display wide and not at
> a character number, correct handling of short duplicates that are not
> duplicate at long form.)
>
> (A fix for CVS would be similar but I would like some feedback before
> porting to CVS.)
>
> Have a nice day!