D5447: Only add auto-detected compilers to model if they actually exist

Milian Wolff <noreply-Buy57tU0AsCGxO/ty/[email protected]>
Newsgroups gmane.comp.kde.devel.kdevelop
Message-ID <[email protected]>
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  sorry for the super long delay. I like what I'm seeing - if this works, please commit

INLINE COMMENTS

> arrowd wrote in compilerprovider.cpp:264
> In other comment you said
> 
> > afaik it's called path since it can be a user-provided absolute path.
> 
> So, if `compiler->path()` can return absolute path, is it OK to pass it as is into `rt->findExecutable()`?

Yes, an absolute path will then just be resolved directly within the RT without looking at the PATH env var of the RT

REPOSITORY
  R32 KDevelop

BRANCH
  d5447

REVISION DETAIL
  https://phabricator.kde.org/D5447

To: arrowd, mwolff, arichardson
Cc: skalinichev, apol, kdevelop-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.