D25587: [KDevelop/PHP] fix rename of a variable

Hugues Mitonneau <noreply-Buy57tU0AsCGxO/ty/[email protected]> Tue, 17 Dec 2019 10:23:19 +0000

Newsgroups	gmane.comp.kde.devel.kdevelop
Message-ID	<[email protected]>

hmitonneau updated this revision to Diff 71708.
hmitonneau added a comment.


  This new patch re-implement `KDevelop::BasicRefactoring::applyChangesToDeclarations` and `KDevelop::BasicRefactoring::applyChanges` in `Php::Refactoring`.
  
  The code is a copy/paste of the virtual function, and just modify the range if we detect that it is a var with a "$". This detection is just a comparison between `range.length()` and `name.length()+1`

REPOSITORY
  R52 KDevelop: PHP Support

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25587?vs=70486&id=71708

REVISION DETAIL
  https://phabricator.kde.org/D25587

AFFECTED FILES
  codegen/refactoring.cpp
  codegen/refactoring.h

To: hmitonneau
Cc: pprkut, kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd