Re: Increasing Qt dependency in master

Hi everyone,

I am new here, I was using kdevelop for my project, since a few things were
bothering me (mostly differences in options between remote and local
debugging), I decided I would have look at the source code.

I managed to build kdevelop using kdesrc-build, which had issues with a
kdevelop qtwebkit dependency, since kdesrc-build uses Qt 5.15, and qtwebkit
is only available up to Qt 5.9. I had to manually compile qtwebkit 5.9
against qtcore 5.15 to get it to work.

Following qmake output if qtwebkit is missing:
-- The following REQUIRED packages have not been found:
 * Qt5WebKitWidgets, <https://qt.io/>
   QtWebKit, for integrated documentation
git show -> commit f124dab2c4423a1dfb5052c4c6fec276ac4bfb23 (HEAD ->
master, origin/master, origin/HEAD)

So about this version bump, is this qtwebkit dependency really required for
documentation? Clicking on User Manual opened a window in Firefox for me.
Or do distribution provides qtwebkit even when deprecated by their Qt
versions?




Am Mi., 28. Okt. 2020 um 18:16 Uhr schrieb Igor Kushnir <[email protected]>:

> On 2020-10-28 18:54, Aleix Pol wrote:
>
> On Mon, Oct 26, 2020 at 11:28 AM Igor Kushnir <[email protected]> <[email protected]> wrote:
>
> On 2020-10-26 12:09, Milian Wolff wrote:
>
> On Montag, 26. Oktober 2020 09:30:30 CET Igor Kushnir wrote:
>
> If we do make the leap to 5.12, I'd like it to be straight to 5.12.1
> rather than 5.12.0 to ease porting from QRegExp::Wildcard to
> QRegularExpression::wildcardToRegularExpression(). The behavior of this
> function was changed in Qt 5.12.1 as it started anchoring its return
> value to fix QTBUG-72539.
>
> Personally I'm fine with that.
>
> What distros would we lose by this move?
>
> Cheers
>
>
> By requiring 5.12.0 we'd lose Debian stable [buster], old Ubuntu LTS
> [18.04] and old OpenSUSE Leap [15.1]. By requiring 5.12.1 we'd not lose
> any extra popular distro version in addition to these 3 releases, I think.
>
> Igor
>
>
> +1 on changing to 5.12.
>
> @Igor: We generally never depend on specific minor versions. In fact,
> I'd expect any maintained distribution to be shipping the last minor
> release, if they don't they're doing a big disservice to their users.
>
> Aleix
>
> Aleix, would you rather *set(QT_MIN_VERSION "5.12.0")*, but assume Qt
> 5.12.1+ to avoid conditional compilation like this
> <https://invent.kde.org/kdevelop/kdevelop/-/merge_requests/151/diffs?commit_id=5fb8ba06389c061bbcadf7bb58529bd185a602f3#b612a43ad13df02f063121d0961522be02a82e7d_27_31>
> ?
>
> Igor
>