Re: KDevelop cpp file causes DoS on CI nodes

On Mon, Jan 23, 2023 at 5:47 AM Igor Kushnir <[email protected]> wrote:

> >> On 2023-01-22 00:17, Ben Cooksley wrote:
> >>> Please do not test any fixes for this issue on the CI system - as it
> will
> >>> cause the Windows (and even potentially FreeBSD) CI worker nodes to be
> >>> killed.
>
> Hi Ben,
>

Hi Igor,


>
> I'd like to amend the last commit in the branch that contains the
> problematic
> file
> https://invent.kde.org/kdevelop/kdevelop/-/blob/work/kdev-clang-cache-types
> by adding the following code:
> ```
>
> Options:
>    cppcheck-ignore-files:
>      # Windows CI nodes are killed by the OOM killer, because cppcheck
>      # uses far $in excess of 8GB of RAM when it tries to process file
>    #
> plugins/clang/tests/files/kdev_ignored/mangle-ms-back-references-pr13207.cpp
>      # Disable checking the directory that contains this file until the
> cppcheck
>      # bug is fixed and a fixed cppcheck version is installed on CI
> servers.
>      - plugins/clang/tests/files/kdev_ignored/
> ```
> at the end of .kde-ci.yml. Is this OK to do or would it count as "testing
> a fix"
> and thus unacceptable?
>

 That seems like a reasonable fix - have you tried running run-cppcheck.py
from sysadmin/ci-utilities (will need to have a cwd of your KDevelop source
tree) to see if that works?


> Thanks,
> Igor
>

Thanks,
Ben