Re: KDevelop cpp file causes DoS on CI nodes

Ben Cooksley <[email protected]> Mon, 23 Jan 2023 10:45:54 +1300
Newsgroups gmane.comp.kde.devel.kdevelop
Message-ID <CA+XidOHb5ESZ=P_MppLq5VjrxCSD4aHUza8+fZpnM5d-duPJhQ@mail.gmail.com>
On Mon, Jan 23, 2023 at 10:27 AM Igor Kushnir <[email protected]> wrote:

>
> On 2023-01-22 22:52, Ben Cooksley wrote:
> >   That seems like a reasonable fix - have you tried running
> run-cppcheck.py from
> > sysadmin/ci-utilities (will need to have a cwd of your KDevelop source
> tree) to
> > see if that works?
>
> Yes. Verified that the patch fixes run-cppcheck.py (after removing
> gitlab-related code from ci-utilities/components/Package.py to be able to
> run
> `python run-cppcheck.py` locally). Pushed the fix and the cppcheck job
> finished
> successfully here: https://invent.kde.org/kdevelop/kdevelop/-/jobs/726113


Thanks for the fix - yes, if it has been tested locally then you are
welcome to proceed :)

I know in the past people have used the CI system to test their fixes hence
the note in my original email.


>
>
> Thanks,
> Igor
>

Cheers,
Ben