kdev-python: Use CMake FindPython3
Casian Andrei <[email protected]> Wed, 3 Jan 2024 16:31:56 +0200
| Newsgroups | gmane.comp.kde.devel.kdevelop |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format.
--------------DZb6kUZLYmBHvISrUD91jMJN
Content-Type: multipart/alternative;
boundary="------------sGZBbQeoL6XGK90sOI7CuC1W"
--------------sGZBbQeoL6XGK90sOI7CuC1W
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Use FindPython3 instead of FindPythonInterp and FindPythonLibs
Fixes CMake warning regarding CMP0148 - deprecation of FindPythonInterp
and FindPythonLibs.
Initially tested using a python3.12, but kdevelop crashes and there are
kdev-python errors in the logs, so kept max version to 3.11.
Tested with a local compiled python3.9. When the python3.9 was compiled
without --enable-shared, CMake didn't work, as expected. When compiled
with --enable-shared, CMake worked fine. Built ok, but for some reason
tried to link kdevpythonlanguagesupport.so to a nonexistent python3.11
library.
Installed a python3.11 which worked fine with kdevelop-python.
I assume that issue linking to a nonexistent python3.11 was not because
of a problem with these changes.
---
Because I haven't contributed to KDE for many years now, it would take a
lot of time to get the accounts and setups and learn how things are done
now.
I hope you are able to review and commit if ok.
Attaching the patch.
--------------sGZBbQeoL6XGK90sOI7CuC1W
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Use FindPython3 instead of FindPythonInterp and FindPythonLibs<br>
</p>
<div>
<div class="edit-comment-hide">
<div
class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block">
<p dir="auto">Fixes CMake warning regarding CMP0148 -
deprecation of FindPythonInterp and FindPythonLibs.</p>
<p dir="auto">Initially tested using a python3.12, but
kdevelop crashes and there are kdev-python errors in the
logs, so kept max version to 3.11.</p>
<p dir="auto">Tested with a local compiled python3.9. When the
python3.9 was compiled without --enable-shared, CMake didn't
work, as expected. When compiled with --enable-shared, CMake
worked fine. Built ok, but for some reason tried to link
kdevpythonlanguagesupport.so to a nonexistent python3.11
library.</p>
<p dir="auto">Installed a python3.11 which worked fine with
kdevelop-python.</p>
<p dir="auto">I assume that issue linking to a nonexistent
python3.11 was not because of a problem with these changes.</p>
<p dir="auto">---</p>
<p dir="auto">Because I haven't contributed to KDE for many
years now, it would take a lot of time to get the accounts
and setups and learn how things are done now.</p>
<p dir="auto">I hope you are able to review and commit if ok.</p>
<p dir="auto">Attaching the patch.<br>
</p>
</div>
</div>
</div>
</body>
</html>
--------------sGZBbQeoL6XGK90sOI7CuC1W--
--------------DZb6kUZLYmBHvISrUD91jMJN
Content-Type: text/x-patch; charset=UTF-8;
name="0001-Use-FindPython3-instead-of-FindPythonInterp-and-Find.patch"
Content-Disposition: attachment;
filename*0="0001-Use-FindPython3-instead-of-FindPythonInterp-and-Find.pa";
filename*1="tch"
Content-Transfer-Encoding: base64
RnJvbSBiNzlkY2Q4MDk4ZTM5ZTBhZmI2NGI4ZWM2MWY5NDc0NmNmNjFmOTg0IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDYXNpYW4gQW5kcmVpIDxjYXNpYW5AY2FuZHJlaS5y
bz4KRGF0ZTogV2VkLCAzIEphbiAyMDI0IDE1OjU2OjEzICswMjAwClN1YmplY3Q6IFtQQVRD
SF0gVXNlIEZpbmRQeXRob24zIGluc3RlYWQgb2YgRmluZFB5dGhvbkludGVycCBhbmQKIEZp
bmRQeXRob25MaWJzCgpGaXhlcyBDTWFrZSB3YXJuaW5nIHJlZ2FyZGluZyBDTVAwMTQ4IC0g
ZGVwcmVjYXRpb24gb2YgRmluZFB5dGhvbkludGVycAphbmQgRmluZFB5dGhvbkxpYnMuCi0t
LQogQ01ha2VMaXN0cy50eHQgICAgICAgICAgICB8IDI1ICsrKy0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0KIGtkZXZweXRob252ZXJzaW9uLmguY21ha2UgfCAxNCArKysrKysrLS0tLS0tLQog
cGFyc2VyL0NNYWtlTGlzdHMudHh0ICAgICB8ICA0ICsrLS0KIDMgZmlsZXMgY2hhbmdlZCwg
MTIgaW5zZXJ0aW9ucygrKSwgMzEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvQ01ha2VM
aXN0cy50eHQgYi9DTWFrZUxpc3RzLnR4dAppbmRleCAxYzFiNjU5ZS4uMTFlODgzYWIgMTAw
NjQ0Ci0tLSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC00MSwy
OCArNDEsOSBAQCBlbmRpZigpCiAKIGFkZF9kZWZpbml0aW9ucyggLURUUkFOU0xBVElPTl9E
T01BSU49XCJrZGV2cHl0aG9uXCIgKQogCi0jIENNYWtlIGxvb2tzIGZvciBleGFjdGx5IHRo
ZSBzcGVjaWZpZWQgdmVyc2lvbiBmaXJzdCBhbmQgaWdub3JlcyBuZXdlciB2ZXJzaW9ucy4K
LSMgVG8gYXZvaWQgdGhhdCwgc3RhcnQgbG9va2luZyBmb3IgdGhlIG5ld2VzdCBzdXBwb3J0
ZWQgdmVyc2lvbiBhbmQgd29yayBkb3duLgotc2V0KFB5dGhvbl9BRERJVElPTkFMX1ZFUlNJ
T05TIDMuMTEgMy4xMCAzLjkgMy44IDMuNyAzLjYgMy41IDMuNCkKLWZvcmVhY2goX1BZVEhP
Tl9WICR7UHl0aG9uX0FERElUSU9OQUxfVkVSU0lPTlN9KQotICAgIGZpbmRfcGFja2FnZShQ
eXRob25JbnRlcnAgJHtfUFlUSE9OX1Z9KQotICAgIGlmICggUFlUSE9OSU5URVJQX0ZPVU5E
ICkKLSAgICAgICAgYnJlYWsoKQotICAgIGVuZGlmKCkKLWVuZGZvcmVhY2goKQotIyBNdXN0
IHVuc2V0IGJlZm9yZSBzZWFyY2hpbmcgZm9yIGxpYnMsIG90aGVyd2lzZSB0aGVzZSBhcmUg
Y2hlY2tlZCBiZWZvcmUgdGhlIHJlcXVpcmVkIHZlcnNpb24uLi4KLXVuc2V0KFB5dGhvbl9B
RERJVElPTkFMX1ZFUlNJT05TKQotCi1pZiAoIFBZVEhPTklOVEVSUF9GT1VORCBBTkQgUFlU
SE9OX1ZFUlNJT05fU1RSSU5HIFZFUlNJT05fR1JFQVRFUiAiMy40IiApCi0gICAgIyBGaW5k
IGxpYnJhcmllcyB0aGF0IG1hdGNoIHRoZSBmb3VuZCBpbnRlcnByZXRlciAobWlzbWF0Y2hl
ZCB2ZXJzaW9ucyBub3Qgc3VwcG9ydGVkKS4KLSAgICAjIFRoaXMgYXNzdW1lcyBsaWJzIGFy
ZSBhdmFpbGFibGUgZm9yIHRoZSBuZXdlc3QgUHl0aG9uIHZlcnNpb24gb24gdGhlIHN5c3Rl
bS4KLSAgICAjIEtEZXZlbG9wIHNob3VsZCBfYWx3YXlzXyBiZSBidWlsdCBhZ2FpbnN0IHRo
ZSBuZXdlc3QgcG9zc2libGUgdmVyc2lvbiwgc28gbm90YWJ1Zy4KLSAgICBmaW5kX3BhY2th
Z2UoUHl0aG9uTGlicyAiJHtQWVRIT05fVkVSU0lPTl9NQUpPUn0uJHtQWVRIT05fVkVSU0lP
Tl9NSU5PUn0iIFJFUVVJUkVEIEVYQUNUKQotZW5kaWYoKQotCi1pZiAoIE5PVCBQWVRIT05M
SUJTX0ZPVU5EIE9SIFBZVEhPTkxJQlNfVkVSU0lPTl9TVFJJTkcgVkVSU0lPTl9MRVNTICIz
LjQuMyIgKQotICAgIG1lc3NhZ2UoRkFUQUxfRVJST1IgIlB5dGhvbiA+PSAzLjQuMyBidXQg
PCAzLjEyIHdpdGggLS1lbmFibGUtc2hhcmVkIGlzIHJlcXVpcmVkIHRvIGJ1aWxkIGtkZXYt
cHl0aG9uIikKLWVuZGlmKCkKK3NldChQeXRob24zX1VTRV9TVEFUSUNfTElCUyBGQUxTRSkK
K3NldChQeXRob24zX0ZJTkRfU1RSQVRFR1kgVkVSU0lPTikKK2ZpbmRfcGFja2FnZShQeXRo
b24zIDMuNC4zLi4uMy4xMS43IENPTVBPTkVOVFMgSW50ZXJwcmV0ZXIgRGV2ZWxvcG1lbnQg
UkVRVUlSRUQpCiAKIGNvbmZpZ3VyZV9maWxlKGtkZXZweXRob252ZXJzaW9uLmguY21ha2Ug
IiR7Q01BS0VfQ1VSUkVOVF9CSU5BUllfRElSfS9rZGV2cHl0aG9udmVyc2lvbi5oIiBAT05M
WSkKIApkaWZmIC0tZ2l0IGEva2RldnB5dGhvbnZlcnNpb24uaC5jbWFrZSBiL2tkZXZweXRo
b252ZXJzaW9uLmguY21ha2UKaW5kZXggOTMxODE0MDEuLjE2MWQ0MDkwIDEwMDY0NAotLS0g
YS9rZGV2cHl0aG9udmVyc2lvbi5oLmNtYWtlCisrKyBiL2tkZXZweXRob252ZXJzaW9uLmgu
Y21ha2UKQEAgLTcsMTUgKzcsMTUgQEAKICNpZm5kZWYgS0RFVlBZVEhPTl9WRVJTSU9OX0gK
ICNkZWZpbmUgS0RFVlBZVEhPTl9WRVJTSU9OX0gKIAotI2RlZmluZSBQWVRIT05fVkVSU0lP
Tl9NSU5PUiBAUFlUSE9OX1ZFUlNJT05fTUlOT1JACi0jZGVmaW5lIFBZVEhPTl9WRVJTSU9O
X01JTk9SX1NUUiAiQFBZVEhPTl9WRVJTSU9OX01JTk9SQCIKKyNkZWZpbmUgUFlUSE9OX1ZF
UlNJT05fTUlOT1IgQFB5dGhvbjNfVkVSU0lPTl9NSU5PUkAKKyNkZWZpbmUgUFlUSE9OX1ZF
UlNJT05fTUlOT1JfU1RSICJAUHl0aG9uM19WRVJTSU9OX01JTk9SQCIKIAotI2RlZmluZSBQ
WVRIT05fVkVSU0lPTl9NQUpPUiBAUFlUSE9OX1ZFUlNJT05fTUFKT1JACi0jZGVmaW5lIFBZ
VEhPTl9WRVJTSU9OX01BSk9SX1NUUiAiQFBZVEhPTl9WRVJTSU9OX01BSk9SQCIKKyNkZWZp
bmUgUFlUSE9OX1ZFUlNJT05fTUFKT1IgQFB5dGhvbjNfVkVSU0lPTl9NQUpPUkAKKyNkZWZp
bmUgUFlUSE9OX1ZFUlNJT05fTUFKT1JfU1RSICJAUHl0aG9uM19WRVJTSU9OX01BSk9SQCIK
IAotI2RlZmluZSBQWVRIT05fVkVSU0lPTiBRVF9WRVJTSU9OX0NIRUNLKEBQWVRIT05fVkVS
U0lPTl9NQUpPUkAsIEBQWVRIT05fVkVSU0lPTl9NSU5PUkAsIEBQWVRIT05fVkVSU0lPTl9Q
QVRDSEApCi0jZGVmaW5lIFBZVEhPTl9WRVJTSU9OX1NUUiAiQFBZVEhPTl9WRVJTSU9OX01B
Sk9SQC5AUFlUSE9OX1ZFUlNJT05fTUlOT1JAIgorI2RlZmluZSBQWVRIT05fVkVSU0lPTiBR
VF9WRVJTSU9OX0NIRUNLKEBQeXRob24zX1ZFUlNJT05fTUFKT1JALCBAUHl0aG9uM19WRVJT
SU9OX01JTk9SQCwgQFB5dGhvbjNfVkVSU0lPTl9QQVRDSEApCisjZGVmaW5lIFBZVEhPTl9W
RVJTSU9OX1NUUiAiQFB5dGhvbjNfVkVSU0lPTl9NQUpPUkAuQFB5dGhvbjNfVkVSU0lPTl9N
SU5PUkAiCiAKLSNkZWZpbmUgUFlUSE9OX0VYRUNVVEFCTEUgIkBQWVRIT05fRVhFQ1VUQUJM
RUAiCisjZGVmaW5lIFBZVEhPTl9FWEVDVVRBQkxFICJAUHl0aG9uM19FWEVDVVRBQkxFQCIK
IAogI2VuZGlmCmRpZmYgLS1naXQgYS9wYXJzZXIvQ01ha2VMaXN0cy50eHQgYi9wYXJzZXIv
Q01ha2VMaXN0cy50eHQKaW5kZXggNzU5MDEwNzguLmNhZjU4ZDRmIDEwMDY0NAotLS0gYS9w
YXJzZXIvQ01ha2VMaXN0cy50eHQKKysrIGIvcGFyc2VyL0NNYWtlTGlzdHMudHh0CkBAIC0x
Niw3ICsxNiw3IEBAIGVjbV9xdF9kZWNsYXJlX2xvZ2dpbmdfY2F0ZWdvcnkocGFyc2VyX1NU
QVRfU1JDUwogICAgIEVYUE9SVCBLREVWUFlUSE9OCiApCiAKLWluY2x1ZGVfZGlyZWN0b3Jp
ZXMoJHtQWVRIT05fSU5DTFVERV9ESVJTfSkKK2luY2x1ZGVfZGlyZWN0b3JpZXMoJHtQeXRo
b24zX0lOQ0xVREVfRElSU30pCiAKIGFkZF9saWJyYXJ5KCBrZGV2cHl0aG9ucGFyc2VyIFNI
QVJFRCAke3BhcnNlcl9TVEFUX1NSQ1N9ICkKIApAQCAtMjYsNyArMjYsNyBAQCBnZW5lcmF0
ZV9leHBvcnRfaGVhZGVyKGtkZXZweXRob25wYXJzZXIgRVhQT1JUX01BQ1JPX05BTUUgS0RF
VlBZVEhPTlBBUlNFUl9FWFBPUgogdGFyZ2V0X2xpbmtfbGlicmFyaWVzKGtkZXZweXRob25w
YXJzZXIgTElOS19QUklWQVRFCiAgICAgS0Rldjo6TGFuZ3VhZ2UKICAgICBRdDU6OkNvcmUK
LSAgICAke1BZVEhPTl9MSUJSQVJJRVN9CisgICAgJHtQeXRob24zX0xJQlJBUklFU30KICkK
IAogaW5zdGFsbChUQVJHRVRTIGtkZXZweXRob25wYXJzZXIgREVTVElOQVRJT04gJHtLREVf
SU5TVEFMTF9UQVJHRVRTX0RFRkFVTFRfQVJHU30pCi0tIAoyLjQzLjAKCg==
--------------DZb6kUZLYmBHvISrUD91jMJN--