Re: [patch] for Bug 50462: mail is permanently lost if disk is full

On Sunday 08 April 2007 4:25:55 pm Martin Koller wrote:
> Hi list,
> 
> attached you find a patch which tries to fix this very high voted issue (>900 
> votes) - which should also work around the same problem noted here:
> Bug 122028: [CRITICAL] KMail corrupts it's index files after a crash. Some/All 
> mails get "No Subject" lines after viewing them. Mails LOST
> 
> It basically automatically recreates the index whenever a "should never 
> happen" situation occurs in getting data from the index and retries to get 
> the requested information.
> 
> I hope someone with deep knowledge about this index stuff can review my patch 
> and tell me if this is something feasible.
> 
> I checked this by corrupting an .index file (with khexedit) by inserting 
> arbitrary data or truncating the file at an arbitrary position.
> 

Martin,

Your patch has an i18n string.
And today is the deadline for new strings.

So, I would say to commit the patch.  We can always back it out later
if Till or Ingo say so.

-Allen