Re: kmheaders.cpp error message could be much more helpful

On Saturday 05 May 2007 12:32, Matthew Toseland wrote:
> On Sat, May 05, 2007 at 03:02:08AM +0100, Matthew Toseland wrote:
> > While trying to determine why kmail doesn't recognise new messages
> > from Maildir folders on my system, I ran into the following error
> > message: WARNING: Error: Failure modifying
> > /home/toad/Mail/.debian.directory/.debian-openoffice.index.sorted
> > (No space left on device?)
> >
> > This is actually hardcoded almost in its entirety - "No space left
> > on device?" is in particular a hardcoded string. It is however
> > caused by a real error - the code is roughly if(fd && ferror(fd)) {
> > complain }.
> >
> > I have attached a patch to include the actual error code.
> > Unfortunately I haven't been able to get the ******* kdepim to
> > compile. This is probably my fault but I've spent several hours on
> > it and not had much success.
> >
> > Patch is against the debian stable package source (3.5.5). May not
> > compile because I haven't been able to make kdepim compile. :|
>
> Sorry, that one will cause a null dereference. Attached a better one.
> Will also say if I manage to compile it.

If error is non-zero then the following might still call ferror() with 
NULL:
     if (error || (sortStream && ferror(sortStream))) {
+       int err = ferror(sortStream);

Moreover, I'd add something like "error code: " before the actual error 
code.

Regards,
Ingo

_______________________________________________
KMail developers mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kmail-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQBGPOxZGnR+RTDgudgRAu/qAKDFtxSSEB3/m8ZUlcOuMzHmrTXUAgCgow7f
iKqrjJoYXzvhAnOFc/T+zbg=
=rvBr
-----END PGP SIGNATURE-----