Re: [Bug 129034] {PATCH] JJ: URL in gnupg "Password Dialog" not clickable
Eugeniu Plamadeala <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kmail |
|---|---|
| Message-ID | <[email protected]> |
Hi!
Alright, I removed that comment.
I also removed a line which now is superfluous.
It inserted a "<qt>" at the beginning of the message because the
KPasswordDialog needed a "<" in order to display it correctly.
My patch for KPasswordDialog got accepted, so it displays things nicely now
without "<".
On Friday 17 August 2007 09:47:40 Thomas McGuire wrote:
> http://bugs.kde.org/show_bug.cgi?id=129034
> Thomas.McGuire gmx net changed:
>
> What |Removed |Added
> ---------------------------------------------------------------------------
>- Summary|JJ: URL in gnupg "Password |{PATCH] JJ: URL in gnupg
>
> |Dialog" not clickable |"Password Dialog" not
> |
> | |clickable
>
> ------- Additional Comments From Thomas.McGuire gmx net 2007-08-17 18:47
> ------- You should also remove the "add #gnupg2 if you can make this a real
> link" comment now.
>
> Anyway, get your KPasswordDialog patch accepted first, then this one can go
--
Best regards,
Eugeniu
************************
[email protected]
www.plamadeala.com
PGP Key ID: 0x486EA33F
************************
_______________________________________________
KMail developers mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kmail-devel
qgpgmejob.diff
(text/x-diff, 1.3 KB)
--- qgpgmejob.cpp 2007-08-16 16:00:20.000000000 -0700
+++ qgpgmejob2.cpp 2007-08-17 12:25:56.000000000 -0700
@@ -258,7 +258,6 @@
i18n( "You need a passphrase to unlock the secret key for user:<br/> %1",
QString::fromUtf8( useridHint ) );
msg += "<br/><br/>";
- msg.prepend( "<qt>" );
msg += i18n( "This dialog will reappear every time the passphrase is needed. For a more secure solution that also allows caching the passphrase, use gpg-agent." ) + "<br/>";
const QString gpgAgent = KStandardDirs::findExe( "gpg-agent" );
if ( !gpgAgent.isEmpty() ) {
@@ -267,11 +266,11 @@
} else {
msg += i18n( "gpg-agent is part of gnupg-%1, which you can download from %2" ,
QString("1.9") ,
- QString("http://www.gnupg.org/download") ); // add #gnupg2 if you can make this a real link
+ QString("<a href=\"http://www.gnupg.org/download#gnupg2\">gnupg.org</a>") );
}
msg += "<br/>";
msg += i18n( "For information on how to set up gpg-agent, see %1" ,
- QString("http://kmail.kde.org/kmail-pgpmime-howto.html") );
+ QString("<a href=\"http://kmail.kde.org/kmail-pgpmime-howto.html\">http://kmail.kde.org/kmail-pgpmime-howto.html</a>") );
msg += "<br/><br/>";
msg += i18n( "Enter passphrase:" );
KPasswordDialog dlg;
signature.asc
(application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBGxfzWy3/7BUhuoz8RAthtAKCdp2cgSivA7hb+iyl77nFQkdoRXQCfSsGl HYnTi0ZsrQHfdlsJJSlltuA= =lxBe -----END PGP SIGNATURE-----