[Bug 53185] Crash when switching message while GPG passphrase entry dialog is shown

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=53185         




------- Additional Comments From iacp free fr  2007-08-23 19:46 -------
Hi there,

I reported a similar issue, although from the looks of it, the problems might be slightly different from one another.

Anyway, for more details look at http://bugs.kde.org/show_bug.cgi?id=149132
aMsg is not valid any more once we come back from the object tree parsing, so I figured that adding a check to see if the current message is aMsg should do the trick there.

It fixed my problem, no more crashes, however I don't know if it might raise some other issues. Maybe some dev could tell us if this is too unorthodox or not. From the looks of it, the aMsg passed to KMReaderWin::parseMsg is initialized to KMReader::message within KMReader::displayMessage, no other call to parseMsg is made elsewhere in the code.

Therefore it seems rather safe to make the assumption that this patch should not introduce other problems, but I think that we'll need another opinion on this matter.

acp