Re: [PATCH] fix for 61305 - After applying filters, old messages re-appear in header listing

On Wednesday 10 October 2007 5:14:25 pm Ingo Klöcker wrote:
> On Wednesday 10 October 2007, Andreas Gungl wrote:
> > Am Mittwoch, 10. Oktober 2007 schrieb Allen Winter:
> > > On Saturday 28 February 2004 4:27:25 pm Andreas Gungl wrote:
> > > > Hi,
> > > >
> > > > please, can someone being familiar with the filtering stuff in
> > > > KMail review the patch? I've tested it and it fixes the behavior
> > > > described in the bug report
> > > > http://bugs.kde.org/show_bug.cgi?id=61305 but I'm nor sure
> > > > regarding possible side effects.
> > >
> > > Hey!  Found this 3.5 year old patch in my email.
> > > It was never committed AFAICS.
> > >
> > > On second look.. the bug report
> > > http://bugs.kde.org/show_bug.cgi?id=61305 claims it was committed
> > > and the bug is closed.  But I don't see the code in the 3.5 branch.
> > >
> > > Anyone know what happened?
> >
> > Hi Allen, the patch was committed in CVS which is r301230 in SVN. It
> > was taken out by Ingo in r311656. I think, the removal was done by
> > accident, but Ingo can certainly better comment on it (if at all
> > after this long time).
> 
> Actually, it was
>   http://websvn.kde.org/?view=rev&revision=294517
> and
>   http://websvn.kde.org/?view=rev&revision=311656
> 
> Usage of CollectingProcess instead of KProcess made Andreas' fix 
> obsolete because it's no longer kmkernel that collects the output of 
> all processes but each CollectingProcess collects its own output. 
> Therefore the output of other processes cannot be mixed.
> 
Cool.  Another mystery solved.

There are dozens of little patches in the kdepim folder that one could
spend many days tracking down and fiddling with.  Most are probably
obsolete by now.

-Allen
_______________________________________________
KMail developers mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kmail-devel