Re: Review Request: Fix for shape paste endless loop in Krita

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5733/#review8451
-----------------------------------------------------------

Ship it!


Only one remark from my side.


/trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h
<http://svn.reviewboard.kde.org/r/5733/#comment8807>

    Is this comment invalid now?


- Boudewijn


On 2010-10-31 12:20:20, Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5733/
> -----------------------------------------------------------
> 
> (Updated 2010-10-31 12:20:20)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> The patch fixes a problem when copy and paste a shape in Krita. The problem is that KoShapePaste does some calculation to have a little offset between old shape and pasted shape. For that it expects that the shape isn't in the shape manager (KoShapePaste line 110 and following). In Krita the shape layer model does add the shape in addShape. The patch changes that so the shape is not added in the model, but in KisShapeController and KisShapeLayerShapePaste.
> 
> 
> This addresses bug 255682.
>     https://bugs.kde.org/show_bug.cgi?id=255682
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/krita/ui/flake/kis_shape_controller.cpp 1191387 
>   /trunk/koffice/krita/ui/flake/kis_shape_layer.cc 1191387 
>   /trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h 1191387 
> 
> Diff: http://svn.reviewboard.kde.org/r/5733/diff
> 
> 
> Testing
> -------
> 
> Tested with copy and paste.
> 
> 
> Thanks,
> 
> Sven
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel