Re: Review Request: bullet color handled in saveOdf

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5743/#review8465
-----------------------------------------------------------



trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp
<http://svn.reviewboard.kde.org/r/5743/#comment8833>

    In many places the saving code has been rewritten to not use 'contains' anymore but instead check that the object that comes out is valid.  (i.e. QColor::isValid())
    
    Maybe thats a strategy to follow for new code too? :)


- Thomas


On 2010-11-01 13:56:21, nandita suri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5743/
> -----------------------------------------------------------
> 
> (Updated 2010-11-01 13:56:21)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> * style:text-properties and fo:color element are saved/written in saveOdf() of KoListLevelProperties.cpp 
> This saves the color of the bullet back in open document format.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp 1191936 
> 
> Diff: http://svn.reviewboard.kde.org/r/5743/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nandita
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel