Review Request: A proper fix for bug 255682
"Dmitry Kazakov" <[email protected]>
| Newsgroups | gmane.comp.kde.devel.koffice |
|---|---|
| Message-ID | <[email protected]> |
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5772/
-----------------------------------------------------------
Review request for KOffice.
Summary
-------
The problem was in KoShapePaste, because it performed setParent() and controller->addShape() calls separately. There is no need to change Krita's part of shape layers for that (that is why this patch reverts commit 1192386).
The change to KoShapePaste was approved by Thomas on a mailing list yesterday.
This addresses bug 255682.
https://bugs.kde.org/show_bug.cgi?id=255682
Diffs
-----
/trunk/koffice/krita/ui/flake/kis_shape_controller.cpp 1193131
/trunk/koffice/krita/ui/flake/kis_shape_layer.cc 1193131
/trunk/koffice/krita/ui/flake/kis_shape_layer_paste.h 1193131
/trunk/koffice/libs/flake/KoShapePaste.cpp 1193131
Diff: http://svn.reviewboard.kde.org/r/5772/diff
Testing
-------
Thanks,
Dmitry
_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel