Re: Review Request: Fix OpenGL texture boundaries
Lukáš Tvrdý <[email protected]>
| Newsgroups | gmane.comp.kde.devel.koffice |
|---|---|
| Message-ID | <[email protected]> |
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5778/#review8526
-----------------------------------------------------------
Ship it!
I think you are awesome.
I did not test, I just reviewed the code style a bit.
/trunk/koffice/krita/ui/opengl/kis_opengl_image_textures.h
<http://svn.reviewboard.kde.org/r/5778/#comment8887>
Is this typedef really needed? Just personal feeling, ignore if you want :)
/trunk/koffice/krita/ui/opengl/kis_texture_tile.h
<http://svn.reviewboard.kde.org/r/5778/#comment8888>
no qDegug(), please
/trunk/koffice/krita/ui/opengl/kis_texture_tile.h
<http://svn.reviewboard.kde.org/r/5778/#comment8889>
qDebug again
/trunk/koffice/krita/ui/opengl/kis_texture_tile_update_info.h
<http://svn.reviewboard.kde.org/r/5778/#comment8890>
qDebug again
- Lukáš
On 2010-11-06 18:54:26, Dmitry Kazakov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5778/
> -----------------------------------------------------------
>
> (Updated 2010-11-06 18:54:26)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> This is a fix for the bug 251113. It fixes both of the issues: border-effect on the boundaries of the textures and the effect on the image->bound().
> It creates an abstraction for a texture tile (KisTextureTile).
> I need some testing now.
>
>
> This addresses bug 251113.
> https://bugs.kde.org/show_bug.cgi?id=251113
>
>
> Diffs
> -----
>
> /trunk/koffice/krita/ui/opengl/kis_opengl_canvas2.cpp 1193131
> /trunk/koffice/krita/ui/opengl/kis_opengl_image_textures.h 1193131
> /trunk/koffice/krita/ui/opengl/kis_opengl_image_textures.cpp 1193131
> /trunk/koffice/krita/ui/opengl/kis_texture_tile.h PRE-CREATION
> /trunk/koffice/krita/ui/opengl/kis_texture_tile_update_info.h 1193131
>
> Diff: http://svn.reviewboard.kde.org/r/5778/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitry
>
>
_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel