Re: Unittests!

2010/11/8 Inge Wallin <[email protected]>:
> On Sunday, November 07, 2010 13:04:42 Boudewijn Rempt wrote:
>> For Krita, I've the habit of sending out a weekly mail with all tests that
>> fail. Here's the same for all of KOffice:
>>
>>
>> The following tests FAILED:
>>          10 - kword-part-TestRdf (Failed)
>>          13 - kformula-LoadAndSave (Failed)
>>          19 - KPlato-EstimateTester (Failed)
>>          30 - kspread-Formula (Failed)
>>          50 - kspread-Sheet (Failed)
>>          80 - krita-image-KisConvolutionPainterTest (Failed)
>>         170 - krita-plugin-format-jpeg_test (Failed)
>>         213 - kotext-odf-TestLoading (Failed) (this one fails because i
>> haven't qtscript installed. I guess it would fail even if I had). 272 -
>> kchart-TestCellRegion (Failed)
>>         278 - shapes-text-TestDocumentLayout (Failed)
>>         279 - shapes-text-TestChangeListCommand (Failed)
>>         284 - shapes-text-TestTextTool (Failed)
>>         285 - shapes-text-TestChangeTrackedDelete (Failed)
>>         286 - kspread-xlsx-FormulaParser (Failed)
>>
>> Note that failing unittests are release blockers. That is, if this list
>> isn't empty, we cannot release 2.3.
>
> Actually, the page about release blockers say that unittests *in the
> libraries* are release blockers [1].
>
>>          13 - kformula-LoadAndSave (Failed)
>
> This one will not get fixed before the release, afaict. The failings is
> because entities, i.e. things like &LargerThan; in MathML, aren't supported.
> That's a regression from 1.6, but was never working in any 2.x version. It is
> indeed a big deficiency, but is it enough to break the feature freeze?

It's not since as you said, never worked but it didn't cause such a
break in the past.
OTOH there's some new failings as reported by Jos after my last
commit. It's expected and no problematic (arguably it's a problem with
tests themselves), yet it should be fixed. I'll do it asap.

> I guess I can disable these parts of the tests if it's important, but that
> seems like a very cosmetic change without much substance.

it could be done if problematic, but should not disable those really failing...
i'd just prefer them to fail since there're failing for a reason, even
if not a blocker.