Re: Review Request: Fix spatial convolution filter

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5807/#review8593
-----------------------------------------------------------

Ship it!


Apart from what I said on IRC about fromDouble:

20:27 < CyrilleB> dmitryK: hum. I would have done it the other way around :)
20:27 < dmitryK> CyrilleB: hm... how?
20:27 < dmitryK> CyrilleB: not partial specialization?
20:27 < CyrilleB> the generic fromDouble with the qRound, and specialization for the 
                  three float type (half, float, double)
20:28 < CyrilleB> the reason is that there is more integer types than float types 
                  (even if, right now, it covers everything we have in krita, but who 
                  knows what might happen in the future)
20:28 < dmitryK> CyrilleB: maybe, <>fromDoubleI() + <>fromDoubleF() ?
20:30 < dmitryK> CyrilleB: or <>fromDouble() + <>fromDoubleF() to conform Qt's style...
20:31 < CyrilleB> dmitryK: you decide
20:31 < dmitryK> CyrilleB: ok
it is all good, ship it.

- Cyrille


On 2010-11-09 19:23:25, Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5807/
> -----------------------------------------------------------
> 
> (Updated 2010-11-09 19:23:25)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Rounding for integers should have been done on a level of KisMathToolbox.
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/krita/image/kis_convolution_worker_fft.h 1193131 
>   /trunk/koffice/krita/image/kis_math_toolbox.cpp 1193131 
>   /trunk/koffice/krita/image/tests/kis_convolution_painter_test.cpp 1194562 
> 
> Diff: http://svn.reviewboard.kde.org/r/5807/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel