Re: Review Request: Fix crash on saving image to KoStore

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5806/#review8598
-----------------------------------------------------------

Ship it!


Please commit :-)

- Boudewijn


On 2010-11-09 18:07:05, Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5806/
> -----------------------------------------------------------
> 
> (Updated 2010-11-09 18:07:05)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> The patch fixes a crash that happens with the oow_pic_in_tiff.odt test file. The problem is that the zip store isn't a normal qiodevice and it will crash in KoStore::seek as the stream is zero.
> The patch adds a temporary buffer for the QImageWriter before write the image to the device.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/libs/flake/KoImageData_p.cpp 1193573 
> 
> Diff: http://svn.reviewboard.kde.org/r/5806/diff
> 
> 
> Testing
> -------
> 
> Tested with oow_pic_in_tiff.odt
> 
> 
> Thanks,
> 
> Sven
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel