Re: Review Request: Fix saving of mirror attributes
| Newsgroups | gmane.comp.kde.devel.koffice |
|---|---|
| Message-ID | <[email protected]> |
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5827/#review8645 ----------------------------------------------------------- Ship it! Nice and simple fix. Not really needed to put it up for review in my opinion. It looks good, but even if it's wrong, the build server will catch it. - vandenoever On 2010-11-10 19:50:10, Sven Langkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5827/ > ----------------------------------------------------------- > > (Updated 2010-11-10 19:50:10) > > > Review request for KOffice. > > > Summary > ------- > > Mirror attributes are saved after the element is closed which leads to invalid odf. > > > Diffs > ----- > > /trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 1195298 > > Diff: http://svn.reviewboard.kde.org/r/5827/diff > > > Testing > ------- > > Tested with oow__pyramid_diagram3.odt > > > Thanks, > > Sven > > _______________________________________________ koffice-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/koffice-devel