Re: Review Request: fix bug:254264, koffice applications crashes when removing view

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5838/#review8684
-----------------------------------------------------------

Ship it!


I'd prefer removing the line -- and the comment, but I've tested it and it works.

- Boudewijn


On 2010-11-12 22:46:25, Cyrille Berger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5838/
> -----------------------------------------------------------
> 
> (Updated 2010-11-12 22:46:25)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> The attached patch fix bug:254264, that happen randomly in any koffice application when removing a view.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/libs/main/KoMainWindow.cpp 1196098 
> 
> Diff: http://svn.reviewboard.kde.org/r/5838/diff
> 
> 
> Testing
> -------
> 
> In Krita, after removing a view, the window is set a minimum size, but this behavior also happen without the patch (even if difficult to reproduce, but sometime, when I don't get the crash I can see the minimum size bug)
> 
> 
> Thanks,
> 
> Cyrille
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel