Re: Review Request: Fixed : Minimised dockers are hiding name. Bug : 201160

> On 2010-11-17 17:01:14, Thomas Zander wrote:
> > /trunk/koffice/libs/widgets/KoDockWidgetTitleBar.cpp, line 137
> > <http://svn.reviewboard.kde.org/r/5868/diff/1/?file=41388#file41388line137>
> >
> >
> 
> Thomas Zander wrote:
>     Hmm, seems reviewboard lost my comment;
>      this line is a close-of-comment. But I fear that the compiler might misunderstand the space in between and it won't compile.

Yes it does cause a problem. I thought I add the compilation error because I made a mistake when copy/pasting :) (yeah efficient way of applying patch). As for the account, Rahul has allready commited things, so it should be ok.


- Cyrille


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5868/#review8784
-----------------------------------------------------------


On 2010-11-16 11:30:23, Rahul Das wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5868/
> -----------------------------------------------------------
> 
> (Updated 2010-11-16 11:30:23)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Minimised dockers are hiding name and shortcut.
> 
> 
> This addresses bug 201160.
>     https://bugs.kde.org/show_bug.cgi?id=201160
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/libs/widgets/KoDockWidgetTitleBar.cpp 1197635 
> 
> Diff: http://svn.reviewboard.kde.org/r/5868/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel