Re: Review Request: Patch for the Krita Junior Job: Call the Edit > Clear action when the Del. key is pressed.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5891/#review8801
-----------------------------------------------------------


I noticed a few things:

-m_delete can be completely removed

-coding style, using tabs instead of spaces

-action is enabled if an empty shape layer is active layer

-if there is a shape selection and one of the shapes is selected, the shape and the selected pixel are deleted

-calling two seperate slots from an action is very unusual, better merge the called slots

- Sven


On 2010-11-17 19:47:26, Francisco Fernandes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5891/
> -----------------------------------------------------------
> 
> (Updated 2010-11-17 19:47:26)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Patch for the Krita Junior Job: "Call the Edit > Clear action when the Del. key is pressed.", in Krita Wishlist.
> The patch eliminate the "Delete Selection" action in the "Edit" menu and merge it's function in the "Clear" action,
> setting the key "Delete" as the shortcut.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/krita/ui/kis_selection_manager.cc 1198182 
> 
> Diff: http://svn.reviewboard.kde.org/r/5891/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francisco
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel