Re: Review Request: Default - empty char format is used for inline (as-char) shapes.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5898/#review8816
-----------------------------------------------------------



/trunk/koffice/libs/kotext/KoInlineTextObjectManager.h
<http://svn.reviewboard.kde.org/r/5898/#comment9458>

    Please don't add a boolean to the public API; see http://chaos.troll.no/~shausman/api-design/api-design.pdf for why.
    
    I suggest a char format instead.


- Thomas


On 2010-11-18 11:21:01, Pavol Korinek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5898/
> -----------------------------------------------------------
> 
> (Updated 2010-11-18 11:21:01)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> insertInlineObject method in KoInlineTextObjectManager class has been changed. Inline object can be inserted using empty - default char format or current cursor char format. Empty - default char format is used for inline (as-char) shapes now.
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/libs/kotext/KoInlineTextObjectManager.h 1198325 
>   /trunk/koffice/libs/kotext/KoInlineTextObjectManager.cpp 1198325 
>   /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1198325 
> 
> Diff: http://svn.reviewboard.kde.org/r/5898/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pavol
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel