Re: Review Request: Default - empty char format is used for inline (as-char) shapes.

> On 2010-11-18 15:13:00, Thomas Zander wrote:
> > /trunk/koffice/libs/kotext/KoInlineTextObjectManager.h, line 80
> > <http://svn.reviewboard.kde.org/r/5898/diff/1/?file=41443#file41443line80>
> >
> >     Please don't add a boolean to the public API; see http://chaos.troll.no/~shausman/api-design/api-design.pdf for why.
> >     
> >     I suggest a char format instead.
> 
> vandenoever wrote:
>     Using a char for anything but ascii characters will eventually cause problems. Better use an enumeration of a bool is not good.

sorry for not being clearer; I didn't mean to imply the usage of a char is correct, I meant to suggest the usage of a QTextCharFormat


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5898/#review8816
-----------------------------------------------------------


On 2010-11-18 11:21:01, Pavol Korinek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5898/
> -----------------------------------------------------------
> 
> (Updated 2010-11-18 11:21:01)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> insertInlineObject method in KoInlineTextObjectManager class has been changed. Inline object can be inserted using empty - default char format or current cursor char format. Empty - default char format is used for inline (as-char) shapes now.
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/libs/kotext/KoInlineTextObjectManager.h 1198325 
>   /trunk/koffice/libs/kotext/KoInlineTextObjectManager.cpp 1198325 
>   /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1198325 
> 
> Diff: http://svn.reviewboard.kde.org/r/5898/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pavol
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel