Re: Review Request: Default - empty char format is used for inline (as-char) shapes.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5898/#review8839
-----------------------------------------------------------


Almost there - see my comment, and also don't forget to change the insert variable action to use current format too


/trunk/koffice/libs/kotext/KoInlineTextObjectManager.cpp
<http://svn.reviewboard.kde.org/r/5898/#comment9468>

    you should still copy the charformat as otherwise the object id may apply to more chars than the inserted object


- Casper


On 2010-11-19 12:12:19, Pavol Korinek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5898/
> -----------------------------------------------------------
> 
> (Updated 2010-11-19 12:12:19)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> insertInlineObject method in KoInlineTextObjectManager class has been changed. Inline object can be inserted using empty - default char format or current cursor char format. Empty - default char format is used for inline (as-char) shapes now.
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/libs/kotext/KoInlineTextObjectManager.h 1198699 
>   /trunk/koffice/libs/kotext/KoInlineTextObjectManager.cpp 1198699 
>   /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1198699 
> 
> Diff: http://svn.reviewboard.kde.org/r/5898/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pavol
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel