Re: Review Request: Default - empty char format is used for inline (as-char) shapes.

"Pavol Korinek" <[email protected]> Fri, 19 Nov 2010 15:00:03 -0000

Newsgroups	gmane.comp.kde.devel.koffice
Message-ID	<[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5898/
-----------------------------------------------------------

(Updated 2010-11-19 15:00:02.945872)


Review request for KOffice.


Changes
-------

charFormat input parameter of method KoInlineTextObjectManager::insertInlineObject is copied before use, method KoTextEditor::insertInlineObject is modifid to use current char format to insert variable.


Summary
-------

insertInlineObject method in KoInlineTextObjectManager class has been changed. Inline object can be inserted using empty - default char format or current cursor char format. Empty - default char format is used for inline (as-char) shapes now.


Diffs (updated)
-----

  /trunk/koffice/libs/kotext/KoInlineTextObjectManager.h 1198699 
  /trunk/koffice/libs/kotext/KoInlineTextObjectManager.cpp 1198699 
  /trunk/koffice/libs/kotext/KoTextEditor.cpp 1198699 

Diff: http://svn.reviewboard.kde.org/r/5898/diff


Testing
-------


Thanks,

Pavol

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel