Re: Review Request: Default - empty char format is used for inline (as-char) shapes.

"Casper Boemann" <[email protected]> Fri, 19 Nov 2010 19:37:30 -0000
Newsgroups gmane.comp.kde.devel.koffice
Message-ID <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5898/#review8846
-----------------------------------------------------------

Ship it!


what happened to the change in textload. We still need that right?

anyway, i assume you just missed it in the diff so i'm going to say ship it, provided yo put that in

- Casper


On 2010-11-19 15:00:02, Pavol Korinek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5898/
> -----------------------------------------------------------
> 
> (Updated 2010-11-19 15:00:02)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> insertInlineObject method in KoInlineTextObjectManager class has been changed. Inline object can be inserted using empty - default char format or current cursor char format. Empty - default char format is used for inline (as-char) shapes now.
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/libs/kotext/KoInlineTextObjectManager.h 1198699 
>   /trunk/koffice/libs/kotext/KoInlineTextObjectManager.cpp 1198699 
>   /trunk/koffice/libs/kotext/KoTextEditor.cpp 1198699 
> 
> Diff: http://svn.reviewboard.kde.org/r/5898/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pavol
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel