Re: Review Request: Set readOnly flag correct

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5910/#review8858
-----------------------------------------------------------



trunk/koffice/libs/main/KoDocument.cpp
<http://svn.reviewboard.kde.org/r/5910/#comment9489>

    This will fail for remote URLs. Well it will assume writable=true, fortunately, so the worst that can happen is an error when saving.
    
    The only way to make this correct for remote URLs would be to do a KIO::stat on the URL, which is async... OK, maybe not worth it.
    
    I would suggest adding a comment like
    
    // Detect readonly local-files; remote files are assumed to be writable, unless we add a KIO::stat here (async).


- David


On 2010-11-20 05:54:51, Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5910/
> -----------------------------------------------------------
> 
> (Updated 2010-11-20 05:54:51)
> 
> 
> Review request for KOffice and David Faure.
> 
> 
> Summary
> -------
> 
> There is a problem with displaying if a file is write protected.
> 
> 1. If you load a write protected file, close it and open a non write protected file it still displays that the file is write protected.
> 2. If you save a write protected file it says the new file is write protected.
> 
> The patch solves both problems
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/libs/main/KoDocument.cpp 1197583 
>   trunk/koffice/libs/main/KoMainWindow.cpp 1197583 
> 
> Diff: http://svn.reviewboard.kde.org/r/5910/diff
> 
> 
> Testing
> -------
> 
> Checked that the flag is correctly shown
> 
> 
> Thanks,
> 
> Thorsten
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel