Re: Review Request: Patch for the Krita Junior Job: Call the Edit > Clear action when the Del. key is pressed.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5891/
-----------------------------------------------------------

(Updated 2010-11-22 03:38:58.029569)


Review request for KOffice.


Changes
-------

Reviews:

m_delete can be completely removed- [Done]

-coding style, using tabs instead of spaces- [Done]

-action is enabled if an empty shape layer is active layer - [Done]

ERROR:

-calling two seperate slots from an action is very unusual, better merge the called slots- [Fail]

Obs.: The method clear() the if selection for detecting a number of shapes doesn't work.


Summary
-------

Patch for the Krita Junior Job: "Call the Edit > Clear action when the Del. key is pressed.", in Krita Wishlist.
The patch eliminate the "Delete Selection" action in the "Edit" menu and merge it's function in the "Clear" action,
setting the key "Delete" as the shortcut.


Diffs (updated)
-----

  trunk/koffice/krita/ui/kis_selection_manager.cc 1199491 

Diff: http://svn.reviewboard.kde.org/r/5891/diff


Testing
-------


Thanks,

Francisco

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel