Re: Review Request: Patch for the Krita Junior Job: Call the Edit > Clear action when the Del. key is pressed.

> On 2010-11-24 08:58:40, Boudewijn Rempt wrote:
> > Apart from the nitpick (and on coding style we can be very precise), looks good. Do you have an svn account already or do you want us to commit it for you?

You can commit for me. I want to do more contributions before have a svn/git account. 


> On 2010-11-24 08:58:40, Boudewijn Rempt wrote:
> > trunk/koffice/krita/ui/kis_selection_manager.cc, line 359
> > <http://svn.reviewboard.kde.org/r/5891/diff/3/?file=41679#file41679line359>
> >
> >     Sorry for being picky, but else needs to go on a new line.

Note taken. :) Should I fix and resend the diff?


- Francisco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5891/#review8951
-----------------------------------------------------------


On 2010-11-23 21:37:30, Francisco Fernandes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5891/
> -----------------------------------------------------------
> 
> (Updated 2010-11-23 21:37:30)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Patch for the Krita Junior Job: "Call the Edit > Clear action when the Del. key is pressed.", in Krita Wishlist.
> The patch eliminate the "Delete Selection" action in the "Edit" menu and merge it's function in the "Clear" action,
> setting the key "Delete" as the shortcut.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/krita/ui/kis_selection_manager.cc 1199491 
> 
> Diff: http://svn.reviewboard.kde.org/r/5891/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francisco
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel