Re: Review Request: Fix loading of curve in softbrush presets

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6046/#review9135
-----------------------------------------------------------

Ship it!


Seems fine to me.

Minor thing: I would document in the code why you decided to add curve string to the base class as it is specialization of the curve* mask generators.

- Lukáš


On 2010-12-04 18:49:14, Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6046/
> -----------------------------------------------------------
> 
> (Updated 2010-12-04 18:49:14)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Patch fixes loading of softbrush curves from presets. For 2.3 branch
> 
> 
> This addresses bug 258420.
>     https://bugs.kde.org/show_bug.cgi?id=258420
> 
> 
> Diffs
> -----
> 
>   branches/koffice/2.3/koffice/krita/image/kis_base_mask_generator.h 1203569 
>   branches/koffice/2.3/koffice/krita/image/kis_base_mask_generator.cpp 1203569 
>   branches/koffice/2.3/koffice/krita/image/kis_curve_circle_mask_generator.cpp 1203569 
>   branches/koffice/2.3/koffice/krita/image/kis_curve_rect_mask_generator.cpp 1203569 
>   branches/koffice/2.3/koffice/krita/plugins/paintops/libpaintop/kis_auto_brush_widget.cpp 1203569 
> 
> Diff: http://svn.reviewboard.kde.org/r/6046/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel