Review Request: as per koffice 2.2, item data sources should be stored in an attribute called report:item-data-source, not report:control-source

"Adam Pigg" <[email protected]> Sun, 05 Dec 2010 19:51:31 -0000
Newsgroups gmane.comp.kde.devel.koffice
Message-ID <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6055/
-----------------------------------------------------------

Review request for KOffice.


Summary
-------

For some reason, brances/2.2 contains a change not in trunk or -essen, that is, before the release of 2.2, when the file format of reports was reviewed, we changed the attribute for the data source of an item to report:item-data-source, from report:control-source.  This patch changes branch/2.3 to match, and should be applied to trunk and -essen also.

KPlato will need a small change to align to this


Diffs
-----

  branches/koffice/2.3/koffice/libs/koreport/items/check/KoReportItemCheck.cpp 1203861 
  branches/koffice/2.3/koffice/libs/koreport/items/field/KoReportItemField.cpp 1203861 
  branches/koffice/2.3/koffice/libs/koreport/items/image/KoReportItemImage.cpp 1203861 
  branches/koffice/2.3/koffice/libs/koreport/items/text/KoReportItemText.cpp 1203861 
  branches/koffice/2.3/koffice/plugins/reporting/barcode/KoReportItemBarcode.cpp 1203861 

Diff: http://svn.reviewboard.kde.org/r/6055/diff


Testing
-------

I have diffed all associated files and this is the only change that needs applied.


Thanks,

Adam

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel