Re: Review Request: as per koffice 2.2, item data sources should be stored in an attribute called report:item-data-source, not report:control-source

I comitted to 2.3 already :) just check the kplato bits i did
-- 
Sent from my Nokia N900

On Mon,   6 Dec 2010, 08:25:05 GMT, Dag Andersen <[email protected]> wrote:

> Made a patch that includes needed changes to kplato and implements
> Jaroslaws   comment.
> (I don't think Adam has much time today)
> 
> Cyrrille, is this something that should go in before RC1?
> 
> -- 
> Mvh.
> Dag Andersen
> 
> Søndag 05 december 2010 21:11:08 skrev Jaroslaw Staniek:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://svn.reviewboard.kde.org/r/6055/#review9141
> > -----------------------------------------------------------
> > 
> > Ship it!
> > 
> > 
> > To avoid broken translation I propose to wait with changing to
> > i18n("Data Source"). Other changes look good.
> > 
> > 
> > - Jaroslaw
> > 
> > On 2010-12-05 19:51:31, Adam Pigg wrote:
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > http://svn.reviewboard.kde.org/r/6055/
> > > -----------------------------------------------------------
> > > 
> > > (Updated 2010-12-05 19:51:31)
> > > 
> > > 
> > > Review request for KOffice.
> > > 
> > > 
> > > Summary
> > > -------
> > > 
> > > For some reason, brances/2.2 contains a change not in trunk or
> > > -essen, that is, before the release of 2.2, when the file format of
> > > reports was reviewed, we changed the attribute for the data source
> > > of an item to report:item-data-source, from report:control-source. 
> > > This patch changes branch/2.3 to match, and should be applied to
> > > trunk and -essen also.
> > > 
> > > KPlato will need a small change to align to this
> > > 
> > > 
> > > Diffs
> > > -----
> > > 
> > > branches/koffice/2.3/koffice/libs/koreport/items/check/KoReportItemChec
> > > k.cpp 1203861
> > > branches/koffice/2.3/koffice/libs/koreport/items/field/KoReportItemFie
> > > ld.cpp 1203861
> > > branches/koffice/2.3/koffice/libs/koreport/items/image/KoReportItemIma
> > > ge.cpp 1203861
> > > branches/koffice/2.3/koffice/libs/koreport/items/text/KoReportItemText
> > > .cpp 1203861
> > > branches/koffice/2.3/koffice/plugins/reporting/barcode/KoReportItemBar
> > > code.cpp 1203861
> > > 
> > > Diff: http://svn.reviewboard.kde.org/r/6055/diff
> > > 
> > > 
> > > Testing
> > > -------
> > > 
> > > I have diffed all associated files and this is the only change that
> > > needs applied.
> > > 
> > > 
> > > Thanks,
> > > 
> > > Adam

<Attachment>   reportdatasource.diff

I comitted to 2.3 already :) just check the kplato bits i did

--

Sent from my Nokia N900

On Mon, 6 Dec 2010, 08:25:05 GMT, Dag Andersen <[email protected] > wrote:

> Made a patch that includes needed changes to kplato and implements

> Jaroslaws comment.

> (I don't think Adam has much time today)

>

> Cyrrille, is this something that should go in before RC1?

>

> --

> Mvh.

> Dag Andersen

>

> Søndag 05 december 2010 21:11:08 skrev Jaroslaw Staniek:

> > -----------------------------------------------------------

> > This is an automatically generated e-mail. To reply, visit:

> > http://svn.reviewboard.kde.org/r/6055/#review9141

> > -----------------------------------------------------------

> >

> > Ship it!

> >

> >

> > To avoid broken translation I propose to wait with changing to

> > i18n("Data Source"). Other changes look good.

> >

> >

> > - Jaroslaw

> >

> > On 2010-12-05 19:51:31, Adam Pigg wrote:

> > > -----------------------------------------------------------

> > > This is an automatically generated e-mail. To reply, visit:

> > > http://svn.reviewboard.kde.org/r/6055/

> > > -----------------------------------------------------------

> > >

> > > (Updated 2010-12-05 19:51:31)

> > >

> > >

> > > Review request for KOffice.

> > >

> > >

> > > Summary

> > > -------

> > >

> > > For some reason, brances/2.2 contains a change not in trunk or

> > > -essen, that is, before the release of 2.2, when the file format of

> > > reports was reviewed, we changed the attribute for the data source

> > > of an item to report:item-data-source, from report:control-source.

> > > This patch changes branch/2.3 to match, and should be applied to

> > > trunk and -essen also.

> > >

> > > KPlato will need a small change to align to this

> > >

> > >

> > > Diffs

> > > -----

> > >

> > > branches/koffice/2.3/koffice/libs/koreport/items/check/KoReportItemChec

> > > k.cpp 1203861

> > > branches/koffice/2.3/koffice/libs/koreport/items/field/KoReportItemFie

> > > ld.cpp 1203861

> > > branches/koffice/2.3/koffice/libs/koreport/items/image/KoReportItemIma

> > > ge.cpp 1203861

> > > branches/koffice/2.3/koffice/libs/koreport/items/text/KoReportItemText

> > > .cpp 1203861

> > > branches/koffice/2.3/koffice/plugins/reporting/barcode/KoReportItemBar

> > > code.cpp 1203861

> > >

> > > Diff: http://svn.reviewboard.kde.org/r/6055/diff

> > >

> > >

> > > Testing

> > > -------

> > >

> > > I have diffed all associated files and this is the only change that

> > > needs applied.

> > >

> > >

> > > Thanks,

> > >

> > > Adam

<Attachment> reportdatasource.diff

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel