Re: Review Request: KPlato: Account reference is not reset when a task becomes summary task.
"Jaroslaw Staniek" <[email protected]> Mon, 20 Dec 2010 22:53:21 -0000
| Newsgroups | gmane.comp.kde.devel.koffice |
|---|---|
| Message-ID | <[email protected]> |
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6078/#review9349
-----------------------------------------------------------
branches/koffice/2.3/koffice/kplato/libs/kernel/kptcommand.cpp
<http://svn.reviewboard.kde.org/r/6078/#comment10351>
This and the addition from SubtaskAddCmd::SubtaskAddCmd() could be shared in a separate private function instead of copy/pasting.
- Jaroslaw
On 2010-12-09 18:45:39, Dag Andersen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6078/
> -----------------------------------------------------------
>
> (Updated 2010-12-09 18:45:39)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> If the user sets an account reference on a task and then makes it a summary task, the account is not reset.
> The result is that the cost from the summary tasks subtask may be added twice giving incorrect totals.
>
>
> Diffs
> -----
>
> branches/koffice/2.3/koffice/kplato/libs/kernel/kptcommand.cpp 1204885
>
> Diff: http://svn.reviewboard.kde.org/r/6078/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dag
>
>
_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel