Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y attributes in EnhancedPathShape
"Casper Boemann" <[email protected]> Fri, 25 Mar 2011 11:48:27 -0000
| Newsgroups | gmane.comp.kde.devel.koffice |
|---|---|
| Message-ID | <[email protected]> |
--===============0363916926==
Content-Type: multipart/alternative;
boundary="===============7022539445483357691=="
--===============7022539445483357691==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
> On March 25, 2011, 11:36 a.m., Inge Wallin wrote:
> > trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp, li=
ne 101
> > <http://svn.reviewboard.kde.org/r/5978/diff/1/?file=3D41722#file41722li=
ne101>
> >
> > I would actually want to register a different opinion: I think that=
empty lines are underrated, and that they add to the clarity of the code b=
y grouping a number of statements. In particular, I think this empty line =
is fine.
> > =
> > I also don't remember anything about discouraging empty lines in th=
e coding standards. Can you point me to where it says anything about it?
Well I like empty lines and use them a lot myself, so in general I agree
but an empty line just after a block start just seems very silly. It doesn'=
t group statements, but rather makes you think it doesn't belong to the if =
clause.
- Casper
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5978/#review10015
-----------------------------------------------------------
On Nov. 29, 2010, 9:48 a.m., Matus Hanzes wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5978/
> -----------------------------------------------------------
> =
> (Updated Nov. 29, 2010, 9:48 a.m.)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> Path-stretchpoint-x and path-stretchpoint-y are needed for example in rou=
nd-rectangles to have the corners round after stretching, without it the co=
rners would be eliptical.
> =
> Bug 258267
> =
> =
> Diffs
> -----
> =
> trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.h 12010=
00 =
> trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 120=
1000 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5978/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Matus
> =
>
--===============7022539445483357691==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"http://svn.reviewboard.kde.org/r/5978/">http://svn.reviewb=
oard.kde.org/r/5978/</a>
</td>
</tr>
</table>
<br />
<blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; padd=
ing-left: 10px;">
<p style=3D"margin-top: 0;">On March 25th, 2011, 11:36 a.m., <b>Inge Walli=
n</b> wrote:</p>
<blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; pad=
ding-left: 10px;">
=
<table width=3D"100%" border=3D"0" bgcolor=3D"white" style=3D"border: 1px s=
olid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan=3D"4" bgcolor=3D"#F0F0F0" style=3D"border-bottom: 1px solid =
#C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href=3D"http://svn.reviewboard.kde.org/r/5978/diff/1/?file=3D41722#f=
ile41722line101" style=3D"color: black; font-weight: bold; text-decoration:=
underline;">trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShap=
e.cpp</a>
<span style=3D"font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style=3D"background-color: #e4d9cb; padding: 4px 8px; text-align: c=
enter;">
<tr>
<td colspan=3D"2"><pre style=3D"font-size: 8pt; line-height: 140%; margi=
n: 0; ">void EnhancedPathShape::updatePath(const QSizeF &)</pre></td>
<td colspan=3D"2"><pre style=3D"font-size: 8pt; line-height: 140%; margi=
n: 0; ">void EnhancedPathShape::updatePath(const QSizeF & size)</pre></=
td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#b1ebb0" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2"></font></th>
<td bgcolor=3D"#c5ffc4" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "></pre></td>
<th bgcolor=3D"#b1ebb0" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">101</font></th>
<td bgcolor=3D"#c5ffc4" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-sp=
ace: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would a=
ctually want to register a different opinion: I think that empty lines are =
underrated, and that they add to the clarity of the code by grouping a numb=
er of statements. In particular, I think this empty line is fine.
I also don't remember anything about discouraging empty lines in the co=
ding standards. Can you point me to where it says anything about it?</pre>
</blockquote>
</blockquote>
<pre style=3D"margin-left: 1em; white-space: pre-wrap; white-space: -moz-pr=
e-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-=
word;">Well I like empty lines and use them a lot myself, so in general I a=
gree
but an empty line just after a block start just seems very silly. It doesn&=
#39;t group statements, but rather makes you think it doesn't belong to=
the if clause.</pre>
<br />
<p>- Casper</p>
<br />
<p>On November 29th, 2010, 9:48 a.m., Matus Hanzes wrote:</p>
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://svn.reviewboard.kde.orgrb/images/=
review_request_box_top_bg.png'); background-position: left top; background-=
repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KOffice.</div>
<div>By Matus Hanzes.</div>
<p style=3D"color: grey;"><i>Updated Nov. 29, 2010, 9:48 a.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Path-stretchpoint-x and path-stretchpoint-y are needed for e=
xample in round-rectangles to have the corners round after stretching, with=
out it the corners would be eliptical.
Bug 258267</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.h <spa=
n style=3D"color: grey">(1201000)</span></li>
<li>trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp <s=
pan style=3D"color: grey">(1201000)</span></li>
</ul>
<p><a href=3D"http://svn.reviewboard.kde.org/r/5978/diff/" style=3D"margin-=
left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7022539445483357691==--
--===============0363916926==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel
--===============0363916926==--