Review Request: Update kword and karbon filters to use libwpd-0.9 and libwpg-0.2
"Robert Mathias Marmorstein" <[email protected]> Thu, 07 Jul 2011 20:07:56 -0000
| Newsgroups | gmane.comp.kde.devel.koffice |
|---|---|
| Message-ID | <[email protected]> |
--===============0805222316==
Content-Type: multipart/alternative;
boundary="===============1005137701151898674=="
--===============1005137701151898674==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101875/
-----------------------------------------------------------
Review request for KOffice.
Summary
-------
This patch updates kword and karbon to use new versions of the libwpX libra=
ries. Mostly this is just a build system change, but required a few minor =
code changes.
Diffs
-----
cmake/modules/FindWPD.cmake 9bd788c =
cmake/modules/FindWPG.cmake eeba521 =
filters/karbon/wpg/import/CMakeLists.txt 7818d71 =
filters/karbon/wpg/import/FileOutputHandler.hxx 811f972 =
filters/karbon/wpg/import/FileOutputHandler.cxx 0f73b3b =
filters/karbon/wpg/import/GraphicsElement.hxx 8367e9a =
filters/karbon/wpg/import/GraphicsElement.cxx 362a71d =
filters/karbon/wpg/import/GraphicsHandler.hxx 8da653d =
filters/karbon/wpg/import/OdgExporter.hxx ad6259a =
filters/karbon/wpg/import/OdgExporter.cxx f386fbf =
filters/karbon/wpg/import/WPGImport.cpp d40c25f =
filters/kword/wordperfect/import/wpimport.cc c45c754 =
Diff: http://git.reviewboard.kde.org/r/101875/diff
Testing
-------
Loaded an old WPD file into kword and some WPGs from the web into karbon. =
Both imported fine. Krazy passes all the files I modified and "make test" =
doesn't indicate any errors in the new code, either.
Thanks,
Robert Mathias
--===============1005137701151898674==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"http://git.reviewboard.kde.org/r/101875/">http://git.revie=
wboard.kde.org/r/101875/</a>
</td>
</tr>
</table>
<br />
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KOffice.</div>
<div>By Robert Mathias Marmorstein.</div>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">This patch updates kword and karbon to use new versions of t=
he libwpX libraries. Mostly this is just a build system change, but requir=
ed a few minor code changes.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Loaded an old WPD file into kword and some WPGs from the web=
into karbon. Both imported fine. Krazy passes all the files I modified a=
nd "make test" doesn't indicate any errors in the new code, e=
ither.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindWPD.cmake <span style=3D"color: grey">(9bd788c)</spa=
n></li>
<li>cmake/modules/FindWPG.cmake <span style=3D"color: grey">(eeba521)</spa=
n></li>
<li>filters/karbon/wpg/import/CMakeLists.txt <span style=3D"color: grey">(=
7818d71)</span></li>
<li>filters/karbon/wpg/import/FileOutputHandler.hxx <span style=3D"color: =
grey">(811f972)</span></li>
<li>filters/karbon/wpg/import/FileOutputHandler.cxx <span style=3D"color: =
grey">(0f73b3b)</span></li>
<li>filters/karbon/wpg/import/GraphicsElement.hxx <span style=3D"color: gr=
ey">(8367e9a)</span></li>
<li>filters/karbon/wpg/import/GraphicsElement.cxx <span style=3D"color: gr=
ey">(362a71d)</span></li>
<li>filters/karbon/wpg/import/GraphicsHandler.hxx <span style=3D"color: gr=
ey">(8da653d)</span></li>
<li>filters/karbon/wpg/import/OdgExporter.hxx <span style=3D"color: grey">=
(ad6259a)</span></li>
<li>filters/karbon/wpg/import/OdgExporter.cxx <span style=3D"color: grey">=
(f386fbf)</span></li>
<li>filters/karbon/wpg/import/WPGImport.cpp <span style=3D"color: grey">(d=
40c25f)</span></li>
<li>filters/kword/wordperfect/import/wpimport.cc <span style=3D"color: gre=
y">(c45c754)</span></li>
</ul>
<p><a href=3D"http://git.reviewboard.kde.org/r/101875/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1005137701151898674==--
--===============0805222316==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel
The KOffice team has split into KOffice and Calligra suite. You find the Calligra project on the [email protected] mailing list. More information at www.koffice.org and www.calligra-suite.org.
--===============0805222316==--