Review Request: Make kword WP import filter compile for me.

"Thomas Zander" <[email protected]> Sat, 09 Jul 2011 13:32:51 -0000
Newsgroups gmane.comp.kde.devel.koffice
Message-ID <[email protected]> 
--===============1176482392==
Content-Type: multipart/alternative;
	boundary="===============0252607034669074816=="

--===============0252607034669074816==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101901/
-----------------------------------------------------------

Review request for KOffice.


Summary
-------

I got a compiler error on ubuntu (11.04   32 bit) due to a method signature=
 difference; the code used size_t and the libwpd header file uses unsigned =
long.
Downloading the tarball of libwpd (0.9.2) I confirmed that the red() method=
 uses unsigned long.  I want to update koffice to follow.


Diffs
-----

  filters/kword/wordperfect/import/wpimport.cc 8c8b8e3 =


Diff: http://git.reviewboard.kde.org/r/101901/diff


Testing
-------


Thanks,

Thomas


--===============0252607034669074816==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable




<html>
 <body>
  <div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href=3D"http://git.reviewboard.kde.org/r/101901/">http://git.revie=
wboard.kde.org/r/101901/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Thomas Zander.</div>





<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">I got a compiler error on ubuntu (11.04   32 bit) due to a m=
ethod signature difference; the code used size_t and the libwpd header file=
 uses unsigned long.
Downloading the tarball of libwpd (0.9.2) I confirmed that the red() method=
 uses unsigned long.  I want to update koffice to follow.

</pre>
  </td>
 </tr>
</table>





<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
 </h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">

 <li>filters/kword/wordperfect/import/wpimport.cc <span style=3D"color: gre=
y">(8c8b8e3)</span></li>

</ul>

<p><a href=3D"http://git.reviewboard.kde.org/r/101901/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============0252607034669074816==--

--===============1176482392==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel

The KOffice team has split into KOffice and Calligra suite. You find the Calligra project on the [email protected] mailing list. More information at www.koffice.org and www.calligra-suite.org.
--===============1176482392==--