Re: Review Request: Fix an annoying CMake warning in the msword-odf filter
"Thomas Zander" <[email protected]> Thu, 08 Mar 2012 19:59:45 -0000
| Newsgroups | gmane.comp.kde.devel.koffice |
|---|---|
| Message-ID | <[email protected]> |
--===============0156811002124959364==
Content-Type: multipart/alternative;
boundary="===============5558507812480104594=="
--===============5558507812480104594==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104192/#review11246
-----------------------------------------------------------
Ship it!
Ship It!
- Thomas Zander
On March 8, 2012, 12:28 p.m., Robert Mathias Marmorstein wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104192/
> -----------------------------------------------------------
> =
> (Updated March 8, 2012, 12:28 p.m.)
> =
> =
> Review request for KOffice.
> =
> =
> Description
> -------
> =
> CMake 2.8 changed the default behavior of the module finding algorithm so=
that it looks in local paths before it looks in system paths. This makes =
a lot of sense and there's no reason not to accept the new behavior. Unfor=
tunately, CMake generates an annoying warning if you don't add a cmake_poli=
cy line to your CMakeLists.txt file approving this change. This patch supp=
resses that warning by accepting the new behavior for that filter.
> =
> =
> Diffs
> -----
> =
> filters/kword/msword-odf/wv2/CMakeLists.txt 2fc0d70 =
> =
> Diff: http://git.reviewboard.kde.org/r/104192/diff/
> =
> =
> Testing
> -------
> =
> Reran cmake and built everything both with gcc and clang. Everything bui=
lds fine and both kword and artwork still run just fine.
> =
> =
> Thanks,
> =
> Robert Mathias Marmorstein
> =
>
--===============5558507812480104594==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"http://git.reviewboard.kde.org/r/104192/">http://git.revie=
wboard.kde.org/r/104192/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spa=
ce: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</=
pre>
<br />
<p>- Thomas</p>
<br />
<p>On March 8th, 2012, 12:28 p.m., Robert Mathias Marmorstein wrote:</p>
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KOffice.</div>
<div>By Robert Mathias Marmorstein.</div>
<p style=3D"color: grey;"><i>Updated March 8, 2012, 12:28 p.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">CMake 2.8 changed the default behavior of the module finding=
algorithm so that it looks in local paths before it looks in system paths.=
This makes a lot of sense and there's no reason not to accept the new=
behavior. Unfortunately, CMake generates an annoying warning if you don&#=
39;t add a cmake_policy line to your CMakeLists.txt file approving this cha=
nge. This patch suppresses that warning by accepting the new behavior for =
that filter.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Reran cmake and built everything both with gcc and clang. E=
verything builds fine and both kword and artwork still run just fine.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>filters/kword/msword-odf/wv2/CMakeLists.txt <span style=3D"color: grey=
">(2fc0d70)</span></li>
</ul>
<p><a href=3D"http://git.reviewboard.kde.org/r/104192/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5558507812480104594==--
--===============0156811002124959364==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel
--===============0156811002124959364==--