Re: Review Request: Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid of make warnings.
"Thomas Zander" <[email protected]> Tue, 13 Mar 2012 18:35:13 -0000
| Newsgroups | gmane.comp.kde.devel.koffice |
|---|---|
| Message-ID | <[email protected]> |
--===============1398146401686454835==
Content-Type: multipart/alternative;
boundary="===============0466406432607333637=="
--===============0466406432607333637==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104252/#review11366
-----------------------------------------------------------
Ship it!
Apart from the comment, this is a good cleanup. Thanks for that!
Do you have a kde account? If so, please feel free to push this commit. If=
not, let us know so one of us can push it for you.
kword/part/KWApplicationConfig.cpp
<http://git.reviewboard.kde.org/r/104252/#comment9098>
The spelling variable now is not going to be used either, so I suggest =
removing this line and the comment above it too.
- Thomas Zander
On March 13, 2012, 4:21 a.m., Chris Smith wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104252/
> -----------------------------------------------------------
> =
> (Updated March 13, 2012, 4:21 a.m.)
> =
> =
> Review request for KOffice.
> =
> =
> Description
> -------
> =
> Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid=
of make warnings.
> =
> =
> Diffs
> -----
> =
> kword/part/KWApplicationConfig.cpp 00e2bcb =
> =
> Diff: http://git.reviewboard.kde.org/r/104252/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Chris Smith
> =
>
--===============0466406432607333637==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"http://git.reviewboard.kde.org/r/104252/">http://git.revie=
wboard.kde.org/r/104252/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spa=
ce: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apart from=
the comment, this is a good cleanup. Thanks for that!
Do you have a kde account? If so, please feel free to push this commit. If=
not, let us know so one of us can push it for you.</pre>
<br />
<div>
<table width=3D"100%" border=3D"0" bgcolor=3D"white" style=3D"border: 1px s=
olid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan=3D"4" bgcolor=3D"#F0F0F0" style=3D"border-bottom: 1px solid =
#C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href=3D"http://git.reviewboard.kde.org/r/104252/diff/1/?file=3D52927=
#file52927line120" style=3D"color: black; font-weight: bold; text-decoratio=
n: underline;">kword/part/KWApplicationConfig.cpp</a>
<span style=3D"font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style=3D"background-color: #e4d9cb; padding: 4px 8px; text-align: c=
enter;">
<tr>
<td colspan=3D"4"><pre style=3D"font-size: 8pt; line-height: 140%; margi=
n: 0; ">void KWApplicationConfig::load(KWDocument *document)</pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#f0f0f0" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">120</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">KConfigGroup</span> <spa=
n class=3D"n">spelling</span> <span class=3D"o">=3D</span> <span class=3D"n=
">KoGlobal</span><span class=3D"o">::</span><span class=3D"n">kofficeConfig=
</span><span class=3D"p">()</span><span class=3D"o">-></span><span class=
=3D"n">group</span><span class=3D"p">(</span><span class=3D"s">"Spelli=
ng"</span><span class=3D"p">);</span></pre></td>
<th bgcolor=3D"#f0f0f0" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">87</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">KConfigGroup</span> <spa=
n class=3D"n">spelling</span> <span class=3D"o">=3D</span> <span class=3D"n=
">KoGlobal</span><span class=3D"o">::</span><span class=3D"n">kofficeConfig=
</span><span class=3D"p">()</span><span class=3D"o">-></span><span class=
=3D"n">group</span><span class=3D"p">(</span><span class=3D"s">"Spelli=
ng"</span><span class=3D"p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style=3D"margin-left: 2em; white-space: pre-wrap; white-space: -moz-pr=
e-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-=
word;">The spelling variable now is not going to be used either, so I sugge=
st removing this line and the comment above it too.</pre>
</div>
<br />
<p>- Thomas</p>
<br />
<p>On March 13th, 2012, 4:21 a.m., Chris Smith wrote:</p>
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KOffice.</div>
<div>By Chris Smith.</div>
<p style=3D"color: grey;"><i>Updated March 13, 2012, 4:21 a.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Removed unused code from "kword/part/KWApplicationConfi=
g.cpp" getting rid of make warnings.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>kword/part/KWApplicationConfig.cpp <span style=3D"color: grey">(00e2bc=
b)</span></li>
</ul>
<p><a href=3D"http://git.reviewboard.kde.org/r/104252/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0466406432607333637==--
--===============1398146401686454835==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel
--===============1398146401686454835==--